Kevin Kreiser

Results 447 comments of Kevin Kreiser

yeah I agree we could come up with a little function to decide what should be marked as a candidate for removal and that could indeed include other ways. with...

this looks good to me, just wondering your thoughts on my comment @johannes-no

we have controls to make sure the data cache for the graph stays below a certain level. it's possible we are missing that for the extra cache that we have...

honestly the fix for it should be straight forward if im correct. any work around would probably be more work than fixing it. ill mark this as a bug and...

there is a slight technical detail here that i thought someone mentioned but i dont see it mentioned here: https://github.com/valhalla/valhalla/blob/3806832a11fe250e08f6f21c9f55da0e052bfc80/src/mjolnir/shortcutbuilder.cc#L69C1-L71C28 we create shortcuts overtop of bridges and tunnels which means...

i also agree with @nilsnolde that we should consider just adding `use_tunnels` to all motorized vehicles. we could move the parsing and factor to the base costing class and just...

yeah i was hoping we could patch it up to the point that it could somewhat work sometimes and be a thing we opt into. maybe in the coming weeks...

interesting hypothesis. imho we shouldn't put them on shortcuts anyway its a duplication without purpose

also we use loki search iirc which doesn't return shortcuts

many apologies @ADMUKHE @johannes-no and @FScholPer im not dragging my feet on this on purpose its all just a matter of finding the time on my end. the original issue...