Kevin Kreiser

Results 447 comments of Kevin Kreiser

@abvhinash i dont have time to triage this right now but this certainly does look like a bug at first glance. ill set the label and come back to it...

this makes me think of something strange with trivial routes. I'll have a look at it later today!

I swear we saw and tried to fix this already but perhaps it's slightly different: https://github.com/valhalla/valhalla/pull/1905

Thank you for narrowing this down, we should be able to debug this pretty quickly now!

so far i couldnt reproduce it with older data, im downloading the latest geofabrik new zealand extract and making data out of that to see if the latest data reproduces...

ok yeah, so basically what is happening is that the algorithm, when the shape is closer will try to do a cheaper map matching algorithm we call "edge_walk". as a...

ok so, before this change: https://github.com/valhalla/valhalla/pull/2712/files#diff-9f54e917f7664c4a402d31eaedf0bc814ec15dc67109945c2af6454a9e232db0L166-L167 we used to pass `options.locations()` to `triplegbuilder::build` because that thing expects loki edge candidates matching the edges in the path to be there. the...

this is a tougher question than it seems unfortunately. by switching to c++17 (which i agree would make our lives easier in so many ways) we also run the risk...

I've updated the OP to reflect the current situation which is c++14 and wanting to move to c++17. Also for posterity, we ended up writing our own thin implementation of...