Kevin Lewis comments

Repositories
Issues
Comments

Results 7 comments of


                                            Kevin Lewis

Adding Coveralls or similar to auto-check new PR for unit tests

Seems like code coverage was never added, currently added the [Code coverage](https://github.com/HEXRD/hexrd/pull/656) PR. I don't think I have permissions to link it to this issue

Small coding style improvements

Null change was reverted

Small coding style improvements

I did try to replace it with None but the test cases threw errors because the comparisons ended up not working. I couldn't figure out why immediately, but I can...

Small coding style improvements

I don't feel like resolving these merge conflicts

Testcases

Check NaN cases in gvec_to_xy. Whenever both gvecToDetectorXYArray and gvec_to_xy return something, they return the same thing. However, NaN's do not match up

Testcases

Moved to PR #696

transforms new_capi version of gvec_to_xy does not use optional arguments bmat and v_inv

You're right, deleted my comment