Kevin Cheng

Results 14 issues of Kevin Cheng

This PR contains the following contract changes to `BaseBulker` and `MainnetBulker` based on OZ's recent audit: - **L-05 Lack of return validation** - We added transfer success checks to these...

openzeppelin

This PR contains changes to the following (mostly stylistic) issues highlighted in OZ's audit: - **L-04 Missing docstrings** - We added a comprehensive set of docstrings to the various constants...

openzeppelin

This PR implements and modifies price feeds to support the upcoming WETH deployment. The favored plan so far is to use ETH-denominated price feeds as opposed to USD price feeds,...

WIP

potential enhancement
revisit

This PR implements a simple and bare-bones simulation (detailed in [RFC 036](https://docs.google.com/document/d/1tguCRfd2EfEdezg7TgCivARCUe_FaxhAeLhC2vb3tDE/edit#heading=h.madcppce2zyp)) for our interest rate models. The goal is to use some basic heuristics to determine the market equilibrium...

enhancement
dependencies

I believe this might be a similar bug to https://github.com/lemurheavy/coveralls-public/issues/1420. I am trying to access a public [repo](https://github.com/compound-finance/comet) that used to be private in Coveralls and getting the access denied...

documentation
troubleshooting
repo-changes

I also change the `verify` step to take in as an argument the artifact from the `prepare` step

As pointed out by spencerperkins on Discord, Comet and CometRewards is missing some events that make off-chain indexing difficult: - `TransferBase` event in Comet - `RewardClaimed` event is missing a...

enhancement

Spider currently expects addresses in `relations.ts` to be all lower case. We should make it case-insensitive. e.g. ``` '0xDbcd5BafBAA8c1B326f14EC0c8B125DB57A5cC4c': { artifact: 'contracts/ERC20.sol:ERC20', }, ``` will not work right now

bug