Kévin Chalet
Kévin Chalet
Given it's technically a behavior breaking change - that requires subscribing to the new OIDC-based service - it would probably make more sense to bump the minor version (i.e 8.1...
> @kevinchalet So do you want to re-version everything as 8.1.0 for releasing this? Yeah, that would be better. In the same vein, we should probably bump the minor version...
@MikeAlhayek nope, no breaking change in 5.5.0 (introducing breaking changes in minor versions isn't really Semver-compliant so I try to avoid it as much as possible, but when there are...
> Why `OpenIddict.Core` has not been updated with the latest version? Ah crap, I missed it during the review. Feel free to fix it 👍🏻
> Normally yes, this is this part that should be reviewed by @kevinchalet. Will do! Let me know if you also want me to take a look at the other...
Wooo, impressive work here 👍🏻 I'll take some time to add more specific comments under the relevant code, but here's a few notes: > All previous `IDataProtectionProvider` usages should use...
I moved your ticket to the correct repository 😃 > Using web providers such as Github is barely documented. In the [Contributing a new Web provider](https://documentation.openiddict.com/guides/contributing-a-new-web-provider.html#test-the-generated-provider), it quickly mentions how...
> but at the start of the authorize I'm checking (like in the samples) if an authentication cookie is available using > > ```cs > HttpContext.AuthenticateAsync(CookieAuthenticationDefaults.AuthenticationScheme); > ``` > >...
Documentation showing how to consume the OpenIddict Web providers was added here: https://documentation.openiddict.com/integrations/web-providers.html 😃
> Describe how to use the correct overloads when using a custom key type or custom entities derived from the default entities. That part is covered by https://github.com/openiddict/openiddict-documentation/commit/eb3fd55b65a82cadf163467cdde4b14121a74e99.