Kai Hao
Kai Hao
> An idea could be to create a small example for a medium/big size DOM comparing the actual solution with your's one. Here's an ad-hoc minimal implementation on [CodeSandbox](https://codesandbox.io/s/dom-testing-library-chain-able-api-performance-test-odbb9?file=/index.test.js). Need...
> I am 99.99% sure it is something that would first need to be incubated in a separate package to be able to judge more thoroughly its real convenience. And...
Oops! I did search for prior arts but couldn't find those! Thanks for the links. Do we still stand by the decision made by @kentcdodds in #266, or does the...
Thanks for the detailed explanation and the reference! They helped a lot! > I'd suggest to issue two `hover()` calls - this forces all browsers to emit a `dragover` event....
Sounds good enough to me! Thanks for the help @dgozman! I think we can close this now. 👍
Thanks for trying it out! I'm currently busy helping out with other things. I'll get back to it soon.
I refactored it to use `useOnBlockDrop` to implement the drop-zone. Haven't yet updated the tests and cleaned up the mess but LMK what you think! https://user-images.githubusercontent.com/7753001/190333398-6b42e10d-4365-43df-9439-147010d4d122.mp4 I'm using the empty...
@youknowriad Seems like the performance regression is from this line: https://github.com/WordPress/gutenberg/blob/9580611aaa63b80a3ac490c11dfa83db52b923e5/packages/e2e-tests/specs/performance/post-editor.test.js#L160-L162 We're creating 1000 empty paragraph blocks to simulate some dummy blocks. However, since this PR, we're now also rendering...
@paaljoachim That issue seems to be an existing one before this PR. If you drop an image between blocks using the "in-between inserter" and click "Undo", it will also enter...
@youknowriad I don't think that's a new problem introduced in this PR though, if rendering dropzones is costly then it should be like that for a while. However, I _guess_...