Kevin McCarthy comments

Results 44 comments of


                                            Kevin McCarthy

mutating requests in before_record_request mutates the actual request returned to the code

Does it also affect the request sent to the server? Should only affect the response that is recorded. Do you mean if you grab the cassette? `with vcr.use_cassett('foo.yml') as cass`...

fix(aiohttp): record body of first request in redirect chain

I gotcha. Thanks for your contribution.

Port aiohttp unread_data to support stream reads

Gotta say this one is over my head, but there seems to be some interest. Any way we can get CI to pass?

Allow environment variables in awslogs-group

Almost the exact same story for me. What I do is template out the elastic beanstalk environment in the dockerrun.aws.json when building the application before zipping and uploading to s3....

Tests failing with Werkzeug >=2.1.0 / remove all use of pytest-httpbin (and httpbin.org) from test suite?

Hmm. I’m a maintainer on httpbin and might be able to move things along over there.

Tests failing with Werkzeug >=2.1.0 / remove all use of pytest-httpbin (and httpbin.org) from test suite?

I have pushed a new version of the httpbin package that has compatibility with updated versions of werkzeug. We needed to fork the httpbin package due to lack of response...

Tests failing with Werkzeug >=2.1.0 / remove all use of pytest-httpbin (and httpbin.org) from test suite?

Good call! It’s here: https://github.com/psf/httpbin

VCR does not accept `pathlib.Path` as cassette path

This PR has been merged! Thanks for your contribution

🛠️ Custom Persister

That is super neat! Is it up on GitHub? We could treat it as a plugin or addon without needing to contribute it to mainline vcr for now.

Migrate to declarative Python package config

Hello! I’m afraid I haven’t been following new developments in Python packaging very closely for awhile now. My general opinion on this is: if it increases compatibility with the newer...