vcrpy icon indicating copy to clipboard operation
vcrpy copied to clipboard

Published 20 hours ago • verified publisher icon kevin1024

Port aiohttp unread_data to support stream reads

Open mikemoritz opened this issue 5 years ago • 5 comments

  • Addresses #502
  • The original test actually identified the issue, so for this change it only needed to returned to the correct output
  • A user will only encounter "unread" data on initial recording if they use the Streaming API, which fails today, so it leaves the primary aiohttp unchanged

mikemoritz avatar Dec 31 '19 14:12 mikemoritz

FYI this change appears to be running into the Black/E203 conflict, and I opted for the Black style: https://github.com/psf/black#slices

mikemoritz avatar Jan 01 '20 15:01 mikemoritz

+1 for finding and fixing this! I just spent ages trying to understand why my streaming responses were empty when using vcrpy. Any chance of pushing it over the line?

martindurant avatar Jul 09 '20 13:07 martindurant

Gotta say this one is over my head, but there seems to be some interest. Any way we can get CI to pass?

kevin1024 avatar Jul 16 '20 15:07 kevin1024

See my patches in https://github.com/dask/gcsfs/blob/master/gcsfs/tests/conftest.py , they may help you

martindurant avatar Jul 16 '20 15:07 martindurant

@mikemoritz were you ever able to check the CI failure on this?

vEpiphyte avatar Oct 02 '20 13:10 vEpiphyte