Kevin Brown-Silva

Results 127 comments of Kevin Brown-Silva

Watching this project from the outside (as the primary maintainer of Select2), the Select2 4.0.0 upgrade is going to affect this project (along with others) in one of two ways:...

Supposedly this works as-is in AngularJS because Select2 4.0 interacts directly with the `` element instead of requiring hacks with the `` element. Has anyone tried it out without using...

Hi everyone! I just discovered this plugin (angular-select2) and noticed this ticket was open. I wouldn't mind taking a shot at converting this over, as long as there are somewhat-updated...

You shouldn't be including the `as_view()` when you register a view into the router. ```python router.register(r'foo', FooViewSet.as_view(), base_name='foo' ``` This should look like ```python router.register(r'foo', FooViewSet, base_name='foo' ```

The issue _sounds like_ DRF is assuming you are working with a single object, but not a queryset. The issue though is that [we are making it clear that it's...

> Another less invasive, but more complex option might be to add a custom many_init classmethod on the BulkSerializerMixin that returns a custom ListSerializer implemented by us. [We already do.](https://github.com/miki725/django-rest-framework-bulk/blob/2a59d14e7036660f00996b013ab913678b5974c4/rest_framework_bulk/drf3/serializers.py#L35-L70)

We just ran into this when creating tests for the bulk serializers. Is there any reason why it is looking for `view` in the context instead of just `request`? The...

I think this could be better clarified in the README to explain DRF < 3.0 requires Django < 1.8, but DRF > 3.0 has no specific Django requirement (it follows...

I think at this point I can definitely say that there are some easy wins for this project in terms of reducing code duplication and aligning with how DRF does...

We should have an added test for the case that was broken before to ensure it doesn't crop up again in the future.