Kevin Turner

Results 201 comments of Kevin Turner

I read #2261 as saying that if an exception such as this AttributeError happens at a particular point, it is handled poorly. Which is important to fix, I agree. but...

A function that returned a CloseableResource go a long way. Even just making this public: https://github.com/junit-team/junit5/blob/43638eb6a870e0d6c49224053dfeb39dcf0ef33f/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TempDirectory.java#L157-L159 No need to do everything by annotations.

@isamu-isozaki is this the approach you've been using?

If you add revision="[fp16](https://huggingface.co/CompVis/stable-diffusion-v1-4/tree/fp16)" to `from_pretrained`, do you still have to do the conversions to `weight_dtype`?

> Maintaining different files is really not that big of a problem and much less of a concern in OSS than in industry settings That hasn't been my experience. but...

Hmm. It successfully uploaded the `junit.xml` written by pytest. But I don't see any sign that it ran the `test_report` action. I don't really know how GitHub Actions works. Do...

The test report artifacts are a means to an end. The goal is to have the reports formatted in a convenient way on the build or the PR. either as...

This likely depends on what settings you have for which actions may run: https://github.com/huggingface/diffusers/settings/actions It depends on - https://github.com/mikepenz/action-junit-report - https://github.com/dawidd6/action-download-artifact neither of which seem to fall under the category...

I think this is still actionable, stale-bot.

an HTML-formatted list of test names and their failure messages (with a clear link to it and not buried in a thousand lines of build output) is pretty much what...