Kevin Turner

Results 201 comments of Kevin Turner

I'd like the roadmap to include a plan for replacing the debug thread view; currently [ThreadMonitorPanel](https://github.com/MovingBlocks/Terasology/blob/0fa1272241b43be94e9920c84a41683643c9f240/engine/src/main/java/org/terasology/engine/monitoring/gui/ThreadMonitorPanel.java#L47) and the [RunningThreads metrics mode](https://github.com/MovingBlocks/Terasology/blob/0fa1272241b43be94e9920c84a41683643c9f240/engine/src/main/java/org/terasology/engine/rendering/nui/layers/ingame/metrics/RunningThreadsMode.java#L14) use ThreadMonitor. https://github.com/MovingBlocks/Terasology/issues/4637 links to a few options that...

Reactor explicitly has [built-in integration with micrometer](https://projectreactor.io/docs/core/release/reference/#metrics), which makes for a good default answer to which of the metrics implementations in #4637 we should use.

Fixed or otherwise no longer relevant, you say? https://drive.google.com/uc?id=1tfnO7-fKyFVoKDmIb7_7AOwBPpwP8nqv&export=download

I have found one reason for making a `-tests` project that builds an independent thing from the main library: code you want to be re-used by other tests. If you...

Sure, it'd be a convenient time to rename it. Relevant terms include: - Integration: it sets up a complex environment in which we test the integration of various different things...

I was going to say "this is probably not too hard," but I didn't expect this: https://github.com/MovingBlocks/Terasology/blob/fbc40c3fe2cf0c605f950c19e6c021f43aa43c05/engine/src/main/java/org/terasology/engine/core/subsystem/headless/mode/StateHeadlessSetup.java#L55-L60 Headless mode **always** loads a save if it can find any! That's useful,...

Here's where MTE sets its home path: https://github.com/MovingBlocks/Terasology/blob/fbc40c3fe2cf0c605f950c19e6c021f43aa43c05/engine-tests/src/main/java/org/terasology/engine/integrationenvironment/Engines.java#L228-L230 so if we want to load things, we either need to put the things in that place, or point it to the...

This works, more or less: https://github.com/Terasology/WildAnimals/blob/158a008ec595daacf61fe8696bae66031859743a/src/test/java/org/terasology/wildAnimals/system/WildAnimalsSpawnSystemTest.java#L148 Leaving the test lifecycle on `PER_METHOD`, then using a static field in the subsystem to keep the home directory the same between tests. Having...

I wouldn't try to tackle this before finishing #4798. I already tried the simple thing of changing the `return false` to a `return true`, and while the first MTE test...

was either Terasology or the other application in full-screen mode?