Ketan Padegaonkar
Ketan Padegaonkar
> Replacing `${escape:$6}` with just `$6` fixes it, but it might have other side-effects. > > @ketan might know more. It does fix, but introduces other problems, don't recall what...
I looked at this. I don't particularly recall what we decided in terms of removal of the code (and the impact it may havve on breaking plugins). Your call on...
Is there a particular reason that this PR is not being merged in?
I've taken the liberty of bumping the version in the changelog, hope that's not going to be a problem. Could you let me know when you release the new binary?...
Sorry, I did not see `EWINDOWS`, since I'm on a mac. I can take a look at implementing this via a an `exec.Command` which waits and exits with the exit...
FYI: `exec.Command` is exactly what I was trying to avoid by replacing the current process with the process corresponding to the args that were passed in.
To be honest, my motivation of doing `exec` was running without a shell/powershell shim on CI systems across different platforms that we want to test with. So I'd much rather...
I'd probably try adding scripts in `/docker-entrypoint.d` and see if that works as expected? See https://github.com/gocd/docker-gocd-agent/blob/2b25324f1b16bf41ebafc607e929a379d6562d45/docker-entrypoint.sh.erb#L113-L124
@MPV Here's how things have been designed: - Stuff in `/docker-entrypoint.d` executes as `root` user, intentionally so. Use this to provision, install packages etc. - Stuff in `/etc/default/go-agent` is sourced...
Use GO_SERVER_URL instead.