Ketan Padegaonkar

Results 44 comments of Ketan Padegaonkar

No hurries, take your time. This will go in the next release of GoCD, due in another month or so. - Ketan On Tue, Jan 29, 2019 at 8:57 AM...

> I'm sorry for going a bit off topic here, but I could not find any thread explaining how to get rid of multiple @Sources. Any hints? Have you seen...

Unfortunately I've not had time to look at this PR, I don't think the situation will change anytime sokn., If someone wants to pick up this PR and make improvements,...

I was looking at the code today, and was left wondering why 4 separate plugins? Could we not have a single plugin with an additional property `Type` or something similar...

I spent some time thinking about it now that I've had enough coffee, it seems like an overkill. Each plugin needs a different set of properties to configure it, so...

Seems to be the same case with: - https://api.gocd.org/current/#get-pipeline-instance - https://api.gocd.org/current/#get-pipeline-history - https://api.gocd.org/current/#get-stage-instance - https://api.gocd.org/current/#get-stage-history

Please merge this PR. I verified that the fix works and is useful. Thanks.

I'm not sure if this will break webpack 1.x compatibility in any way... Based on [this spec](https://github.com/mipearson/webpack-rails/blob/2da71f0a31ad5c68838783d192445e88247a2b41/spec/manifest_spec.rb#L7-L13), it looks like the manifest.json is supposed to look like — ```json {...

@mipearson — may I get some thoughts on my comment above?

I did some quick analysis of the current code and here's a summary of the *existing* implementation: 1. The `stages` table in the DB keeps track of stages where artifacts...