kernelkind
kernelkind
@iduartgomez Are you working on this issue? If not, I'd like to attempt it if that's ok
I've got a bunch of changes to add for this MR including a devimint test and backend test, but I've got a question before I push any changes. https://github.com/fedimint/fedimint/blob/c1cb0e6207779dd8441f4c3798caa6471e2b15ec/gateway/ln-gateway/src/rpc/rpc_server.rs#L182-L189 I...
> I'm confused, where are you seeing this? The gateway should not panic on any error, if it does, that's a bug. Ah I was mistaken. I saw this line:...
I can remove the `scripts/tests/backend-leave-fed-test.sh` and `scripts/tests/gateway-leave-fed-test.sh`, I just used them for easier testing
> Another idea: what happens if gateway only has dust? I think we should still be able to leave, otherwise they'd need to deposit and withdraw to get back to...
I made it optional, but the backwards compatibility test still fails. It's weird, why would it fail before supplying the `--forced=true` flag? I would understand if it failed because the...
A less elegant solution that I think wouldn't break the backwards compatibility tests is to revert the `LeaveFed` command and create a new one called `LeaveFedForced`. And `LeaveFedPayload` would be...
This method in `v0.2.1` returns `Result` instead of `Result`: https://github.com/fedimint/fedimint/blob/a8422b84102ab5fc768307215d5b20d807143f27/gateway/ln-gateway/src/lib.rs#L874-L885 so in the test `gateway_leave_fed_test FM: current CLI: current GW: v0.2.1`, the `v0.2.1` rpc_server for gateway sends `Ok(())` https://github.com/fedimint/fedimint/blob/a8422b84102ab5fc768307215d5b20d807143f27/gateway/ln-gateway/src/rpc/rpc_server.rs#L143-L149 But...
If we wanted to use `v0.2.2` it looks like 4aa6495 would need to be chery-picked here as well since it doesn't have the `Result` return type for `handle_leave_federation` etc. It...
I'm working on this