Kenyon Ralph

Ubuntu 20.04 still has an old version of certbot, so we can't merge this as is. https://packages.ubuntu.com/focal-updates/certbot

I can recommend using our systemd module to configure systemd-networkd instead.

Your module installation is broken if `init.pp` is missing. You shouldn't be declaring the `php::fpm` and `php::packages` classes, they are private.

If you're quoting it in hiera, then it's a string. I think the problem is the ERB template, the [decorate](https://github.com/Bauer-Xcel-Media/puppet-gitlab/blob/a24e00d7484769dc9fd52c3b435bf59d04e84bdb/templates/gitlab.rb.erb#L4) method in particular. #146 appears to be a report about...

Yeah, the numerical value is the same regardless of the radix. So I guess this is more of a cosmetic problem. Still would be good to convert the template to...

You can use `postfix::config` for these settings, as shown in the examples: https://github.com/voxpupuli/puppet-postfix/blob/master/REFERENCE.md#postfixconfig

You may read the code, but I don't see anything in this module that would manage those settings.

This link from https://github.com/jfrog/jfrog-cli/issues/277#issuecomment-440280090 is now broken and I'm really having a hard time finding the current location of documentation on using JFrog CLI with internal certificate authorities: https://www.jfrog.com/confluence/display/CLI/CLI+for+JFrog+Artifactory#CLIforJFrogArtifactory-UsingSelf-signedSSLCertificates

Do you need to run every OS in the Vagrantfile just to generate facts for one new OS? Seems like there must be a better way.

That error message is a common problem and yeah makes it tough to debug. I remember it from https://github.com/puppetlabs/puppetlabs-docker/issues/749 too.