Kenyon Ralph

Should be closed, this doc was added in #1262.

Could you add a test for this too? Seems like there's a similar one already here: https://github.com/voxpupuli/puppet-nginx/blob/master/spec/classes/nginx_spec.rb#L495

Yeah I think adding the severity as a class parameter to https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/resource/server.pp is the way to go, similar to the parameters already there which are taking their value from the...

Rebased.

@zipkid you can use regexp in the `lookup_options`, would that work for converting to `Sensitive`? Might have to arrange your data structure differently, not sure how it looks. https://puppet.com/docs/puppet/7/hiera_merging.html#setting_lookup_options_to_refine_the_result_of_a_lookup-lookup-options-format

All it takes is a pull request implementing it, with tests, and it would be done!

Hmm, I seem to remember that if you install the package `redhat-lsb-core` then those facts are available.

Well, the `os` fact is structured, so to test that properly you would do this: ``` % facter os.distro.codename buster ``` That fact should exist.

For reference, the docs for this are here: https://www.jenkins.io/doc/book/managing/cli/#downloading-the-client

> Do we need more changes or it could be merged? We need the tests to pass. I rebased on latest master and squashed the commits.