kennytm

Results 391 comments of kennytm

@tliron > But why would it be a distinct ACP from this issue, which is titled "Parse IPv6 zone identifiers"? it is a distinct ACP because this one is talking...

log location: https://github.com/pingcap/tiflow/blob/3cf60079e1d73101c376138aed3cb1be2a409704/engine/framework/master.go#L692-L695

> Should there be a way that users can make their own aliases that work for RPIT *and* APIT? Or is this only useful for Iterator and Future? > >...

The last-field limitation actually means nothing ABI-wise since the Rust layout allows reordering the fields ```rust use std::{ptr::NonNull, mem::offset_of}; struct MySmartPointer { extra: u16, interior: NonNull, } fn main() {...

@programmerjake > the Rust compiler is what chooses what order the fields are in, which also means the Rust compiler can always leave the unsizable field at the end, as...

@scottmcm `#[repr(transparent)]` won't work for types which are allocator-aware such as `Box` / `Rc` / `Arc` etc. Granted, `Box` does not implement `DispatchFromDyn` (only `Box` does), plus `allocator_api` is still...

The issue with forcing `#[repr(transparent)]` is that the type `MyBox` can't exist at all, even if we only want `impl DispatchFromDyn for MyBox`. And if you don't `#[repr(transparent)]` then dispatching...

> If there is a simple solution to this, even if it's a breaking change, then I'm open to patches. I think *maybe* a parser option to set the span...

@lolbinarycat I think the Pre-RFC URL is wrong (currently it links to `#[doc(consts)]`), it should be https://internals.rust-lang.org/t/pre-rfc-must-use-false/21861 right?