Alberto Vena

Results 245 comments of Alberto Vena

@rafaelfranca added a new config named `config_manifest` for this. Let me know if this works!

Another improvement (maybe with another PR) could be falling back to the Sprocket 3 behavior (`app.config.assets.precompile += [LOOSE_APP_ASSETS, /(?:\/|\\|\A)application\.(css|js)$/]`) if the configuration manifest does not exist. Do we really need...

@rafaelfranca hey there, is there any thing I can do to move this forward?

@rafaelfranca friendly ping if you have time to point me in a good direction to move things forward here. Thanks!

Closing this one, but thanks for the effort Ale!

@coorasse I rebased this against master and resolved a conflict. If specs pass, I'll go head and add the backport labels to have this on recent support versions of Solidus...

@waiting-for-dev do you have any idea about why ensure and triage actions have not been triggered here? 🤔

Checking if this is still a bug. Locally the provided specs are not failing to remove the change to the fulfillment changer class. Just pushed the spec only to see...

I can reproduce the failing spec. Will push an update soon.

I pushed an updated version with more unit specs and the implementation of [this suggestion](https://github.com/solidusio/solidus/pull/3338#pullrequestreview-291083699).