solidus_i18n Normalize translations

Hi everyone, follow up from https://github.com/solidusio/solidus_i18n/pull/146. I'd like to check for the translation files to be normalized using the i18n-tasks check-normalized task. I added it to the Travis configuration and I simply ran i18n-tasks normalize on all translation files. No manual work has been made in this PR, all changes to the files have been done by the normalize task. I add this information to simplify the code review because the changes are many. One note: the normalize task adds an empty space on keys without a value (see here). I am asking myself why do we have keys without value? is there a reasoning behind that or can we simply remove them? In case we want to keep them we would have to live with the empty space. This check seems the most interesting at the moment because this gem is not covered (of course) by a lot of tests. Some improvements on this side will come in a separate PR.

Apr 06 '19 08:04 coorasse

Related issue: https://github.com/glebm/i18n-tasks/issues/319

Apr 06 '19 08:04 coorasse

I think the empty keys are there because someone originally copied the en version (from Solidus core). Of course, there's no reason to keep them at this point since the core file is out of sync.

Aug 06 '19 08:08 kennyadsl

Currently bundle exec i18n-tasks check-normalized behaves differently locally and on TravisCI. I need to investigate the issue.

Aug 06 '19 08:08 coorasse

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Nov 11 '22 11:11 stale[bot]

Closing this one, but thanks for the effort Ale!

Jul 18 '23 07:07 kennyadsl