Kenneth Stark

Results 18 comments of Kenneth Stark

+1 to this. With moderate sized apps this bug takes a rather large performance hit.

Is your player in a scroll view? I have the same issue but it occurs when a user touches the video player to scroll. Only on Android

try ```js router.navigate(`/(two)/${encodeURIComponent(payload)}`); ``` or ```js router.navigate(`/(two)?myParam=${encodeURIComponent(payload)}`); ```

@marklawlor I believe the latest commit https://github.com/expo/expo/pull/26597/commits/f2a0c2f0628f714a34b68312c0361f0faa985ded should fix the issues. I'm not quite sure how to write a test case exactly for this issue as it depends on when...

The issue still occurs with url queries ie /path/to/route?**query=test**. Route still doesn't push when the url query param changes. Has something to do with the parent state nesting params, where...

@marklawlor This fixes routing pushing to slug routes, however, there is still a bug for the same thing but with url query params. ie route/to/slug**?query=test** Looks like url queries aren't...

Related https://github.com/expo/expo/issues/26916

> Related #24600 Hey @marklawlor I think the pushOrPop feature is good, however, I don't think it totally solves this issue. In my use case the new feature would just...

This patch seems to be working for me. https://github.com/expo/router/issues/758#issuecomment-1813200769

> The params do not affect the screen names, Expo Router essentially uses the file path as the screen name, but that logic isn't used as the state is generated...