Ken Loeffler

Results 66 comments of Ken Loeffler

> I would be more than okay with that for Rojo 7.4.1. It's important to get it working and we'll have it fixed properly soon enough anyway. Should we just...

This is closed by #865 (I properly linked this issue with the correct keyword in the PR, what are you doing github)

Hey @blackshibe, do you have any roblox model files that exhibit this behavior that you can PR to [rojo-rbx/rbx-test-files](https://github.com/rojo-rbx/rbx-test-files)? We like to have real files to test against whenever we...

I think there are two different issues being conflated here. First, model pivots don't work with `rojo build`. After some investigation, there's actually nothing wrong with how rbx-dom serializes model...

> Regarding NeedsPivotMigration, should this be something Rojo implicitly does from now on? I haven't been able to find much documentation on PVInstance.NeedsPivotMigration, so I'm not entirely certain if it...

> I'm looking into working on the above changes. Should I create a new PR to address both problems, starting over? I've created an issue at #385 for the "missing...

@Crystalflxme @blackshibe I've created an issue over at rojo-rbx/rojo#866 and a corresponding one for this project at #391, and I've also hacked a fix together for the `NeedsPivotMigration` problem at...

Can't repro as of 7.4.3, so I'm closing this issue. Please let me know if you're still seeing this problem!

Looked into this more, and it's going to be difficult (or impossible) to give much useful info (e.g. the instance's full name) in these errors because the DOM is necessarily...