Kelvin Stinghen

Results 52 comments of Kelvin Stinghen

@tjmehta. IMHO it will be very good to get this in a configuration, just for now. What do you think? When I get some time, maybe I open a PR...

Well, here we go: > Organization for abilities (not so important) > I want work with one file for each model abilities. For example: person_abilities.ex and product_abilities.ex. Isn't that possible?...

> I think not. The defimpl accept in for, in my case, CompanyMember that is the first argument in can? definition and that's it. Well, I didn't understand why not....

Thanks @HammamSamara, marked this as a 2.0 feature, let's wait for a bit and group some other changes with it to make the major worth it

Perfect! That one can be released in a minor version

> Hi Kelvin, > > I have been looking through the code. Without testing it looks like: > > 1. Remove :`tenant_prefix` from the Config module > 2. Update `Triplex.to_prefix(tenant,...

Today, `Triplex.all` actually return the schema names, so if the db has one tenant called `"test"` and the prefix is `"tenant_"`, it will return `["tenant_test"]`. The problem with that is...

> will you merge the pull request with `master` and then if you are happy bump the version number and create a branch? Yep, that's the plan

Basically, it is an option to add a prefix to all tenant schemas. That is good to avoid conflicts with other schemas on the db. Also useful to be allowed...

Yeah, postgres and mysql should work the same. Will review your work soon, thanks for the PR. Best, Kelvin Em 4 de nov. de 2020 00:00 -0300, Andrew Barr escreveu:...