Kelson

Results 4085 comments of Kelson

I believe quite a few things should be changed in this listing. This is one of them.

> > Very similar to [#986](https://github.com/openzim/wp1/issues/986), maybe this is just a visualising problem and this progress visual is not properly under control? > > Not the progress "visual" itself, but...

@ShaopengLin For me, it does not compile: ``` r/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o suggestionlistmodel.o src/suggestionlistmodel.cpp src/suggestionlistmodel.cpp: In member function ‘void SuggestionListModel::resetSuggestions(const QStringList&)’: src/suggestionlistmodel.cpp:110:21: error: loop variable ‘suggestion’ creates a copy...

> For 1: To clarify, do you mean grey the 'Select All' checkbox? I am assuming this as we don't have 'true' multi-zim search yet. So having this feature enabled...

@veloman-yunkan I will check a last time rhat everything works fine but so far I'm concerned LGTM. Can you pleaee start with the code review?

@ShaopengLin Restesting with `ed182d2`, and an other computer, and many things are NOK (and IMHO regressions as it was working before) there: * "Add new tab" tab width - just...

> @kelson42 What is the font family used in the mock-up? All the details are [here](https://github.com/kiwix/kiwix-desktop/wiki/kiwix-desktop-2-concept)... but please don't take measure to change the default font. If you see something...

> @veloman-yunkan @kelson42 Code review should hold off. To have the exact spacings like the mock up, will need a somewhat large architectural change to this PR (due to Qt...

> @kelson42 I am mostly talking about the spacing between icon and text. I agree with you the fonts and boldness are easy to change. OK, do your best to...

@ShaopengLin Any news here so I can make a new review pass? A rebase would be welcome too.