Kelson

Results 4116 comments of Kelson

@ShaopengLin Can you please rebase and fix conflict? @veloman-yunkan Can you please do the code review?

@veloman-yunkan Are we finally ready to merge?

@ShaopengLin Would that be easy to just remove the filter in such situation, so user starts again on a fresh foot?

@ShaopengLin Let me merge this and I will test it first. This PR is too old already...

@mgautierfr @nickhuang99 What is the status here? Is that ready to merge?

We want to keep things compiling on older compilers. The strategy is to allow c++ 14 features but not higher.

We have to compile on cpp14 compilers, therefore we should not use moderner breaking forms. Do you have some kind of detailed report showing that the code is not cpp14...

I speak under the control of @mgautierfr and @veloman-yunkan but the agreement between us was "you can compile and respect the c++17 norm but not use c++17 new features". But...

@Popolechien @benoit74 Do you have an opinion on this?

AFAIK everything (we are in charge) should lead you to https://library.kiwix.org/ and all the .torrent are available there. Thx for reporting but honestly this is not clear to me how...