Kelly

Results 25 comments of Kelly

If you've got time, go for it :) I think the ellipsis addition should be fairly straightforward, but the en/em dash one could be a little tricky to account for...

See comments on PR #5.

I'm reopening this due to not implementing anything else and the re-emergence of this topic here: https://github.com/kellym/smartquotesjs/issues/28.

This is definitely a valid PR. +1 to merging.

@bkosborne would you mind sharing how you're calling smartquotes? I have an implementation that allows passing in ignored tags, but I want to make sure your use-case is covered before...

I added tests and removed duplicate code. Sorry for the delays in adding changes. Should be ready whenever you like, pending passing tests.

Anything left preventing this from being merged?