Fix: remove tagging label when clicked in dropdown

[kellym]

This fixes #1806.

This bug was introduced from PR #1727.

Here is a plunker to represent the issue: http://plnkr.co/edit/zv41jdiLa2eylIdM9tu8. When you type in a new field and click on it (don't press enter), the tagging label gets included in the tag.

This fix adds a tiny bit of duplicate code from line 417-ish of the same file, but this particular area of code seems potentially fragile, so I opted minimal changes. Ideally this whole lot of code needs to change to improve the way this text is removed, since a string replace could lead to erroneous string replacements, but there is some traffic on #1806 and it was a significant issue for our team in production.

[Jefiozie]

Hi,

Thanks for submitting the PR. Could you maybe create a function to remove the duplicated code? Also I would like to have some tests to verify if this will work in the single and multiple select situation. Can you arrange this?

Thanks.

[tduchateau]

We look forward to seeing it merged! :-)

[Ledragon]

Hey, Any update on this? Is something actually preventing the merge?

[marc-thomas]

+1

[gorn]

+1 (https://github.com/nextcloud/contacts/issues/444 depends on it)

[skjnldsv]

👍

[kellym]

I added tests and removed duplicate code. Sorry for the delays in adding changes. Should be ready whenever you like, pending passing tests.

[kellym]

Anything left preventing this from being merged?

[skjnldsv]

@Jefiozie bump? :heart:

[kaybee41906]

+1

[kellym]

Is this repo maintained anymore?

[CesarD]

@Jefiozie any news on this and why it's not merged yet? Has been sitting for some time already...

[bsarkadi]

@Jefiozie I'd need this fix as well, any news on it?

[gorn]

Is there a problem which blocks accepting this? It is needed in https://github.com/nextcloud/contacts/issues/444

[HerbertMarshall]

Would love to have this fixed.....

[gorn]

What tests this exactly needs? And what work? Should the labels be removed?