Jan Winkelmann

Results 108 comments of Jan Winkelmann

I added references to the places in the spec. There are checks that we don't do at all, and these are closely tied to features we don't implement properly yet...

This seems to be addressed by the frankenstein framework. Should we close this and open individual issues for missing functionality?

Most notably, add info on the Storage trait.

We recently added a test for a check that we hadn't tested before: https://github.com/openmls/openmls/pull/1590 I'll go through the list of required checks today and see whether we now have everything.

Checks: - [ ] [103](https://openmls.tech/validation.dhall/#103): Verify that the LeafNode is compatible with the group's parameters. If the GroupContext has a required_capabilities extension, then the required extensions, proposals, and credential types...

I restructured the test code for group context extensions a little bit. I wasn't sure how to best use the test framework, so what I did is I moved some...

Note: The linked PR contains all the updates.

Sounds good! I switched to core::error, formatted and rebased. For the hashmap it looks like the best way would be to use the [hashbrown](https://crates.io/crates/hashbrown) crate - my understanding is that...

I'll see what I can do. I've been using the cmake build system before to build ibex, and it looks like that branch doesn't support that. Let me see if...

> SGTM. FYI, I'm using `CXXFLAGS=-std=c++0x ./waf configure --enable-shared --with-optim --with-solver --with-affine-extended --interval-lib=filib --lp-lib=clp` to configure it. Thanks, this came just in time, my build without these arguments just failed...