Keith Pitt

Results 44 comments of Keith Pitt

I'd like to hear more about this! Specifically the approached taken in this PR vs: > Providing a digest here should avoid the need to vendor plugins for the sake...

I'm cool with the approach in general (as mentioned on the call). I'd like to float a different syntax: ``` steps: - command: "go build -o dist/my-app ." artifact_paths: "./dist/my-app"...

This change probably plays into a more general redesign of how timeouts should be handled. Timeouts are managed by Buildkite at the moment. We have a CRON job that essentially...

Doh, I totally missed your response here @pda! I think it's totally reasonable that something can happen within the agent that would cause the job to not finish cleanly, and...

Still probably a good thing to add! Just makes working with hooks a bit easier and more explicit (instead of magical files in a folder somewhere). Although in a new...

Currently global and local hooks run side by side, I'd imagine inline hooks perform the same way.

> Would we just be adding global, plugin, repository, inline? Sorry, yeah that!

@lox feels on renaming to `--allow-plugin-if` ?

We use `if` in the `pipeline.yml` file, so I was thinking of using the same-ish nomenclature with the `if`

Just had a sneaky chat with @lox about this, and I think the answer for us is to support a graceful restart of the agent, which would reload any config...