Keith Mattix II

Results 442 comments of Keith Mattix II

This feels reasonable to me; wdyt @jaellio @whitneygriffith?

Interesting...when I didn't add the istio.io/rev label, the Gateway infra was never created; I'll have to go and double check. I think the revision label _is_ supported/intended and we should...

> If you only have a revisioned istiod - I think you do need istio.io/rev label ( can be on the Gateway object itself - I don't think we document...

Figured out why I couldn't reproduce it: non-labeled, revisioned gateway creation works in the default namespace, but all other namespaces fail and the informers don't even seem to get the...

Hmm yeah this seems like a reasonable use case but I worry it could be abused in the future and create a split horizon control plane

Fixed in #49855

/unit-tests-arm64_istio flake

#50061 (there's a backport to 1.21) fixes it and #47407 broke it

Oh I missed that this was Lua; my bad

I think this is mostly complete after istio/proxy#5472 and the accompanying cherry-pick. The only thing missing is destination principal