Keith Mattix II
Keith Mattix II
I think this will be complete with the release of v1.1
True, but we probably shouldn't write tests assuming that a feature flag that defaults to off is turned on. Tests depending on that behavior can just set the feature flag...
@nshankar13 if this is already default true in 1.21+, then I think this is probably fine right? @howardjohn SetForTest probably helps reduce the overhead, but probably moot at this point...
Ah this is for e2es you're right 🤔 yeah the separate test suite for each dependent test is a pain but doable if needed. +1 that dynamically changing likely breaks...
I lost track of this, but let's track it for 1.23.
Can this be closed?
Hi @zhlsunshine i didn't realize this proposal was out; taking a look
Perhaps the ask is specific to the kubernetes.io/* protocols? ~I think there was already a PR submitted for that though~ Yep #43988
If you set a default revision when installing, all resources that don't have a revision label will be validated by the istiod that has that default revision