Keith Smiley
Keith Smiley
that's a great tip! note that for use with the rule based toolchain if you have a toolchain like: ```bzl cc_toolchain( name = "clang_toolchain", ... ``` The target you need...
It seems like in the proto representation from this i get 3 duplicate entries 1 after the other, any idea how to eliminate that? it just adds some noise to...
are you thinking a top level bazel flag, or a magic feature to opt out of this behavior, or? also is there a bug in the implementation that only google...
pushed a boolean to that file which can disable this behavior, wdyt about that? idk how your replacements for that file work but I assume it might have the downside...
ptal @matts1
cc @comius any other ideas on how to fix? I think this blocks us supporting bazel 9.x in the apple rules
this is the resulting trace with 8.4.2: ``` ERROR: /Users/ksmiley/dev/bazelbuild/apple_support/test/test_data/BUILD:41:22: in starlark_apple_binary rule //test/test_data:macos_binary: Traceback (most recent call last): File "/Users/ksmiley/dev/bazelbuild/apple_support/test/starlark_apple_binary.bzl", line 7, column 41, in _starlark_apple_binary_impl link_result = link_multi_arch_binary(...
looks like this workaround works: ``` build_common_variables = apple_common.compilation_support.build_common_variables if hasattr(apple_common, "compilation_support") else compilation_support.build_common_variables common_variables = build_common_variables( ctx = ctx, toolchain = cc_toolchain, deps = deps, attr_linkopts = attr_linkopts, )...
looks like that workaround approach works for 8.x and HEAD but not rolling, so i guess there was an intermediate step where the API existed but didn't fully work