Keith Smiley
Keith Smiley
one case i noticed the output paths were something like `bazel-bin/path/to/binary.lto/bazel-out-k8-dbg-ST-whatever/path/to/artifact`, i assume these aren't being stripped
Yea I wasn't suggesting removing that, but we probably need custom error handling because that isn't set
not sure i want to merge this since it actually breaks more than it fixes until we fix other rules_cc compat issues
the same goes for a BUILD file like this: ```bzl [ some_target(...) for x in ["list"] ] package(default_visibility = ["//visibility:public"]) ```
ah thanks for the context, in my case it was more like: ```bzl targets() lists = [] targets() package() ``` and so maybe it could be at least moved up...
potential improvement here to be a bit more greedy with it: https://github.com/bazelbuild/buildtools/pull/1422
i don't know why i didn't convert this one at the time, it seems trivial, i sent an internal PR to do this that should hopefully land soon
https://github.com/modular/modular/commit/1f1d0f7bf266520485e9c09eee33701050f573cb
yes, if you want to submit a PR that'd be awesome!
I don't feel strongly about this, but you're right that it was because iOS existed before the --cpu type options were no longer recommended, so the google folks didn't implement...