Keith Smiley

Results 1356 comments of Keith Smiley

sounds good, updated to that. Looks like using parse_headers fails in python headers either way right now (at least on macOS): ``` % bazel build ... --process_headers_in_dependencies --features=parse_headers ... Use...

I think this one is good to go

I think we need to re-sync the headers from the swift release branch, since these are actually undefined maybe they've been added since we last did that

https://github.com/MobileNativeFoundation/swift-index-store/releases/tag/1.8.0

In general instead of using this one you should add this to your .bazelrc: ``` build --copt=-ffile-compilation-dir=. --host_copt=-ffile-compilation-dir=. ``` Ideally we would add this to this ruleset, but it wouldn't...

looks like as far back as 13.x. im not sure if anything in these rules are doing that now, but yea ideally

My understanding is that bazel always uses `_virtual_includes` because that is how it prunes the files that can be included to only the ones you define in your `hdrs`, and...

note that this repo mostly just doesn't use any of the old stuff for this either since it just shells out to the default toolchain setup code. https://github.com/bazel-contrib/toolchains_llvm/blob/bb3f7d0171129e8f168f51f3deebdbe010e2bf00/toolchain/cc_toolchain_config.bzl#L368

FWIW I rolled out a toolchain internally using the new stuff with a custom sysroot and vendored clang and it's working well. But it does still require some patches on...