Keith Smiley
Keith Smiley
@pzembrod I think we're good here?
hopefully helpful rules_cc pr https://github.com/bazelbuild/rules_cc/pull/463
threading the needle a bit here, if we update past https://github.com/withered-magic/starpls/pull/382/ we need this, otherwise we don't
I could use that in my custom rule alongside the toolchain itself, but I was thinking that this might make sense as an attribute on the toolchain. To be more...
Our case is pretty unique, this is with the [mojo programming language](https://www.modular.com/mojo) which offers python interop, so I need to tie together the actual python toolchain we want it to...
looks like the commit that introduced this was rolled back https://github.com/protocolbuffers/protobuf/commit/f58849b60344fea170103ce7ae83d34d5a489c5b maybe a googler can comment on if that's going to come back out, or if this patch is irrelevant
i don't feel strongly about the defs.bzl part since realistically these rules shouldn't be disabled, but happy to try to go that route and add that upstream to unify this...
@vladmos @comius another one for you, CI issue is infra
Ah yes parse_headers using these makes sense. I assume @fmeum is right and these flags are specific to Google, since they aren't valid AFAICT. If it's for parse_headers I suppose...