Keith Smiley comments

Results 1357 comments of


                                            Keith Smiley

Use `includes` instead of `system_includes` for `includes` attr

totally fair, I can add this behind an incompatible flag, before I do that on this one, should we consider https://github.com/bazelbuild/bazel/pull/25751/ or should I close that and move forward with...

Use `includes` instead of `system_includes` for `includes` attr

it looks like there is another implementation option, we can use `feature_configuration.is_requested` instead of `is_enabled` so that toolchains don't have to contain the feature, then I imagine it could be...

Use `includes` instead of `system_includes` for `includes` attr

I've updated to the `is_requested` approach because the tests have the same issue

Use `includes` instead of `system_includes` for `includes` attr

ok the CI failures here lead to some interesting discoveries. for one the BUILD files of both grpc and c-ares have undeclared inclusion errors lurking that only hit if you...

Use `includes` instead of `system_includes` for `includes` attr

rebased, no direct conflicts so im hoping we're still good here

Use `includes` instead of `system_includes` for `includes` attr

thanks!

Fix cc_import.includes to work like the other rules

I'm not sure how safe this is to change, but also I don't see how any values in this field were valuable before?

Fix cc_import.includes to work like the other rules

rebased and green!

Delete osx_cc_wrapper.sh

should see on CI that it's still required for bazel before 8.x

Delete osx_cc_wrapper.sh

looks like this works with 7.x even though `--incompatible_macos_set_install_name` wasn't flipped, i guess that means the fixes made it in there and then it works because we just ignore the...