Delete osx_cc_wrapper.sh

Open keith opened this issue 9 months ago • 4 comments

This was only used to fix the install_name of shared libraries, which is now obsolete since they are set correctly by the crosstool with -install_name.

Mar 27 '25 23:03 keith

should see on CI that it's still required for bazel before 8.x

Mar 27 '25 23:03 keith

looks like this works with 7.x even though --incompatible_macos_set_install_name wasn't flipped, i guess that means the fixes made it in there and then it works because we just ignore the flag value in this PR (since it's no longer valid to be disabled with this change)

Mar 28 '25 19:03 keith

Looks like https://github.com/bazelbuild/bazel/commit/4956dff50d21a3346c1a63985910df10fccfd90b is what fixed it. Not sure we should move our minimum up to 7.4.0 just yet?

Mar 31 '25 19:03 brentleyjones

yea good point we can wait a bit

Mar 31 '25 19:03 keith