Justus Magin

Results 532 comments of Justus Magin

closing in favor of pydata/xarray#9197

closing this in favor of pydata/xarray#9056: we've been discussing this for a while in the datatree meetings, and the version in `xarray` actually supports inheritance (implemented in pydata/xarray#9063).

closed in favor of pydata/xarray#9346

I don't think we should support backslashes in datatree paths either, group paths should have nothing to do with filesystem paths (just like urls this should always be the same...

> But having just one level could be possible, something like `(section (header) (content))`, but not sure how useful would that be. not sure about syntax highlighting, but when analyzing...

~`numpydoc` makes use of `docutils`, so I guess it expects [the same behavior](https://github.com/numpy/numpydoc/blob/017e74acd6e45af06e20a9e1ce7cdd8510b11412/numpydoc/docscrape.py#L291-L345) (not sure though, I'm no expert on that code base).~ Edit: It appears that `numpydoc` is splitting...

~In addition to the string dtype failures (the old ones, `U` and `S`)~: numpy/numpy#26270 ``` xarray/tests/test_accessor_str.py::test_case_str: AssertionError: assert dtype('

we also have a failing `strategy` [test](https://github.com/pydata/xarray/actions/runs/8638322254/job/23682526243?pr=8854#step:8:2460) (hidden behind the `numpy.array_api` change): ``` FAILED xarray/tests/test_strategies.py::TestVariablesStrategy::test_make_strategies_namespace - AssertionError: np.float32(-1.1754944e-38) of type ``` not sure if that's us or upstream in `hypothesis`...

@dcherian, did we decide what to do with the dtype casting / promotion issues?