Justus Magin

Results 348 comments of Justus Magin

with this, all the tests pass locally (except the doctests, which I didn't try yet). ~For them to pass in CI as well, we need a released version of `xarray`'s...

with the recent commits, this should be ready for reviews (cc @TomNicholas, @benbovy, @jthielen). Note that even though the index implements a couple of the methods of the custom index...

> So right now `indexes` is a valid argument to the `DataArray` constructor but not to the `Dataset` constructor? What exactly are you referring to? Not sure if this is...

and I get ``. Either way this looks fine.

`iris` has the pin in their package metadata

I wonder if it would not be better to solve this using the map-reduce pattern? For computing differences, the idea would be to first compute the element-wise differences, then group...

this should be fixed in `dask` since quite a while ago, but I'll leave it open until we have tests for this (probably after copying the test suite from `xarray`)

this completes successfully: ```python subset = ds.assign_coords(time=ds.time.astype("datetime64[ns]")).isel(time=slice(-3,-1)) for var in subset.variables.values(): var.encoding.pop("filters", None) subset.to_zarr('foo.zarr', mode='w') ds = xr.open_dataset("foo.zarr", engine="zarr").load() ``` `cftime` is only involved with dtypes that are not exactly...

See https://github.com/pydata/xarray/issues/6318#issuecomment-1056924176 for the `datetime64` handling > I wonder what those filters contained? Can we make an example of this with a pure xarray dataset? the `repr` of those is:...

sorry, my bad, the attrs have nothing to do with this, and they are not affected by the `pop`, either. Edit: for reference, it's `.zarray` that contains the filters: ```json...