Keean Schupke

Results 326 comments of Keean Schupke

It seems the only way we know it is an encapsulated image is because of the transfer encoding. What I need is a way to defragment the data in the...

I like the idea of "dicomParser.isEncapsulated()"

Can I get access to DICOM properties from inside "readDicomElementExplicit"? For example I want to check the TransferSyntax, but the dataSet is not passed into "readDicomElementExplicit" as a parameter, is...

There is a problem with getting the data needed for "isEncapsulated()". The normal method requires the element.length which is straightforward. The patched version will need the byte-stream (to check if...

I have submitted a pull request. Does it look okay?

Any news on the pull request? I am about to deploy the fixes, and I would like to know if these changes are going to get incorporated into the dicomParser...

Quick follow up, installing "rollup-plugin-polyfill-node" does not fix the issue, as there are properties used buy the aws-sdk that are not available in the polyfills. For example some of the...

``` import nodeResolve from '@rollup/plugin-node-resolve'; import commonjs from '@rollup/plugin-commonjs'; import multiEntry from '@rollup/plugin-multi-entry'; import typescript from 'rollup-plugin-typescript2'; import includePaths from 'rollup-plugin-includepaths'; import progress from 'rollup-plugin-progress'; import sizes from 'rollup-plugin-sizes'; export...

A futher point is that Rollup does actually produce an output with the above config, its just that the output has the following undefined symbols: ``` path (guessing 'path') fs...

Here is a smaller version of the config, that still has the same error: ``` export default [{ input: ['src/client.tsx'], output: { format: 'iife', sourcemap: true, name: 'client', file: 'build/client.js'...