Kyle Conroy

Results 225 comments of Kyle Conroy

at this point I just want to ensure that what is stored is a string, is casting not ok for that, do we need to check the type and call...

> Well, what would it be if not a string nor Unit? It can't suddenly be a number, can it? Exactly. Since I don't need to override the formatting, I...

> If this is to fix a bug, do we need a new regression test? Working on it - it isn't as easy as it might seem because the existing...

@MarianConstantinMarica - sure, that would be great! No one is actively working on this at the moment, so feel free to open a PR if you find a solution (or...

I see this is only with one image layer, but is the app in WCS or pixel linking mode? See https://github.com/spacetelescope/jdaviz/blob/bef7a001f1a61a0df034c730c08d2843b1d82227/jdaviz/core/freezable_state.py#L131-145 for the relevant logic being triggered here: ``` #...

ok, in that case I suspect the bug is somewhere in that if-statement or how the orientation WCS handles mapping this flat onto the sky (cc @bmorris3)

no, in this case they will be in world coordinates (and are exposed as editable at the top of plot options, with units attached). In that case, maybe this is...

> Does this mean that zoom_center_x/y reports its coordinates based on how it's aligned, and switches when the alignment type changes? Yes https://github.com/user-attachments/assets/029696b8-e312-46f8-846f-aabeaff8af39

@javerbukh - can you still reproduce this or do you think it was closed by #1992? [:cat:](https://jira.stsci.edu/browse/JDAT-3042)

looks like all the failing tests are in Mosviz and Specviz2d (which do not yet have the unit conversion plugin, so is unsurprising). Once #3156 is in, we can bring...