Kyle Conroy

Results 225 comments of Kyle Conroy

@Jenneh @pllim - I'd be happy to work on any UI tweaks. I do see approximately equal padding on the top and bottom (although it is small - but the...

> And this blocks 4.0? This is not listed as required for 4.0. In fact, if we _do_ merge it, we may want to consider postponing exposing the API so...

Now that the notebooks are updated, that would make this official public API (we can no longer just defer exposing the API), so do we want to milestone this beyond...

I personally think its ok if the base logic lives in an internal call. The plugin provides a UI and API interface to the user, but that doesn't always make...

If we decide to replace `apply_roi` entirely, I think that could be a follow-up ticket, the scope of this has already extended quite a bit beyond the original scoped API.

What if `import_region` took `create_new=True` (which we could have either default to True or False) to allow deciding whether to listen to the currently selected subset and combination mode, or...

> Setting subtools._obj.combination_mode = 'new' at the beginning gives me a long traceback at the first import_region Do we understand the cause for this? Maybe it can be a separate...

looks like there has been a glue release since that upstream PR was merged - can we update the requirements and revive this?

Eventually we want a cube in `counts` to be coerced into `counts/pix**2` ("surface brightness" units) and for SBflux to still work to toggle between `counts/pix**2` and `counts`. This is probably...

> I'm not sure if this is semantics or if there is a scientific value, but, what would the angle_unit.selected be for a flux unit? (Eventually) if a cube with...