Alex Grebenyuk
Alex Grebenyuk
Hey, @crazytonyli , @jkmassel , I would appreciate your feedback on this one. If there is something you'd like to improve, let me know. I tested only the following scenarios...
iPad needs more work. This is how it currently works in production: Looks like it was never designed for iPad. Since I identified that this screen is not a blocker...
> Or, maybe displaying the no site view at "My Site" tab, and not using the split view controller at all. I agree. I'll try to make it work with...
The original report of the empty state view issue: https://github.com/wordpress-mobile/WordPress-iOS/issues/14547
I updated the implementation and here are the latest screenshots. This change covers the "no sites" scenario.
I had to rebase but I put the PR comment updates in a separate commit.
Btw, if you have any idea how to fix the highlighting of this button, that would be great. The root case is this line: ```swift configuration.preferredSymbolConfigurationForImage = UIImage.SymbolConfiguration(paletteColors: [.secondaryLabel, .secondarySystemFill])...
Good catch. I added some defensive code to hide the popover if the sidebar is no longer displayed. I think it should cover all the main scenarios.
Fixed in the redesigned version of the picker.
Something is wrong with this PR. It keeps marking my replies as "Pending". I addressed the feedback, and here was the reply about the filters UI/UX: > It might be...