WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Reader: Implement new cells

Open kean opened this issue 1 year ago • 4 comments

This PR adds the initial implementation of the new post cells for the Reader. The new cells use smaller vertical space, have better accessibility support for both dynamic type and voice over, and has new menus.

There is still a little bit more work left, but it's mergable and it's completely under the new feature flag.

Changes

Before and After

The vertical size usage comparison:

feed-before feed-after

Dynamic Type

accessibility-01 accessibility-02 accessibility-03

Context Menus

context-menu-1 context-menu-2

To test:

  • Context menu actions still work

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

kean avatar Oct 11 '24 20:10 kean

1 Warning
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

dangermattic avatar Oct 11 '24 20:10 dangermattic

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23670-f338663
Version25.4
Bundle IDorg.wordpress.alpha
Commitf338663f7b6549d633e539306b38546aae516d85
App Center BuildWPiOS - One-Offs #10823
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Oct 11 '24 20:10 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23670-f338663
Version25.4
Bundle IDcom.jetpack.alpha
Commitf338663f7b6549d633e539306b38546aae516d85
App Center Buildjetpack-installable-builds #9865
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Oct 11 '24 20:10 wpmobilebot

I had to rebase but I put the PR comment updates in a separate commit.

kean avatar Oct 16 '24 11:10 kean