Alex Grebenyuk
Alex Grebenyuk
There were at least a couple more feedbacks like this since it was originally reported – seems worth addressing.
I'm going to close it for now because it will need to be largely re-implemented for the new editor.
I honestly didn't read the tests because the use of Alamofire didn't seem to make sense. > but we should replace it with static test data that can be validated...
> Sorry to be annoying – can we use multi-line Swift strings for this so developers can read it right in the code? Can you drop a comment on the...
> We could probably just use that in the test for easier comparison? It actually is, isn't it? There are just boundaries and .utf8 "blobs". I tried it, but there...
But this will work: ``` let expected = "--testboundary\r\nContent-Disposition: form-data; name=\"key-1\"\r\n\r\na\r\n--testboundary\r\nContent-Disposition: form-data; name=\"key-2\"\r\n\r\nb\r\n--testboundary--\r\n".data(using: .utf8) ``` I'm changing it to that.
**RCA**: the main tabs are reloaded but the Site Switcher shown on the root VC is not dismissed
### RCA The app uses the old path `/following/manage` instead of `https://wordpress.com/read/subscriptions`. The old `/following/manage` path also opens the wrong screen on iPhone – it should open "manage subscriptions".
Updates: - Added remaining channels: "First Posts", "Latest", "Daily Prompts" - Added observer for tags (ManagedObjectsObserver) - Added support for new `site_icon` field in Discover
Fixed by https://github.com/wordpress-mobile/WordPress-iOS/pull/23918