Refresh post when it is opened

[kean]

This PR introduces the “post refresh” mechanism that was cut from the original scope of 24.9 to reduce the complexity. When you open a post for editing the app will now fetch the latest version of the post. Now if you tap a cached post before the list finishes refreshing, the app will guarantee that you will still see the latest version of the post. We hope that it will reduce the number of data conflicts when saving posts (post_repository_conflict_encountered).

There are a few caveats:

• Refreshing a post takes time (expected range is ~200-500ms) and we don’t want to slow down opening the editor. This means that refresh has to happen in parallel with the editor initialization. If the post is already up to date, the editor doesn’t even need to reload.
• You should be able to close the editor in case the refresh is taking too much time. If you do, and the request eventually fails, the app shouldn’t show the error snackbar.
• The “Autosave Available” dialog should be shown based on the latest post content and after the refresh completes
• The editor has it own loading animation. Ideally, we would tap into it, but with lack of an API, I ended up showing an overlay on top of it similar to what you find on wp.com

Out of the scope: adding support for “Not Found” scenario. It depends on fix/missing-original-assertion-when-updating-not-found-page, and I’d prefer to ship it in 25.2 once this change is proven.

https://github.com/wordpress-mobile/WordPress-iOS/assets/1567433/e59ae2ea-b887-4a3a-9c1a-8ebf1ffc5dd6

Scenario 1

• (App) Open post list and wait until it fetches the latest posts
• (Web) Modify and save one of the posts
• (App) Select the modified post
• ✅ Verify that the post shows the latest data

Comments in code:

• This should be unreachable as [self] will be weak, but adding it just in case
  • We want to make sure that if you close the editor before the refresh finishes, it doesn’t affect other parts of that
• When the editor opens, it immediately creates a revision, so we have to add this, unfortunately. If we end up rethinking the editor, this will be one thing to refactor.

To test:

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• [ ] I have completed the Regression Notes.
• [ ] I have considered adding unit tests for my changes.
• [ ] I have considered adding accessibility improvements for my changes.
• [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• [ ] WordPress.com sites and self-hosted Jetpack sites.
• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] VoiceOver.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] iPhone and iPad.
• [ ] Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23364-6a27273
	Version	25.1
	Bundle ID	com.jetpack.alpha
	Commit	6a272730a2be4ce31513d3e8dec54c3b7b3ae7d5
	App Center Build	jetpack-installable-builds #9225

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23364-6a27273
	Version	25.1
	Bundle ID	org.wordpress.alpha
	Commit	6a272730a2be4ce31513d3e8dec54c3b7b3ae7d5
	App Center Build	WPiOS - One-Offs #10176

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[kean]

I'm going to close it for now because it will need to be largely re-implemented for the new editor.