Kostas Dermentzis

Results 88 comments of Kostas Dermentzis

Additionally is there any efficient helper function to get the number of blocks made in the current epoch? We will most probably define `startIndex = resultSize * blocksMade`

Hm I guess folding this mapping for _every_ block may not be that efficient. Maybe we can have conditions to stop this folding when `blocksCounter * resultSize >= stake.size` or...

This currently seems suprisingly slow ``` cexplorer=# select min (block_no) from block where epoch_no = 319; min --------- 6842099 (1 row) Time: 1172,601 ms (00:01,173) ``` We would need to...

I wouldn't rely on the auto-incremental block.id, but yes we can find some other query ``` select count(*) from block where epoch_no = 319; count ------- 8401 (1 row) Time:...

The auto-incremental block.id is managed internally by postgtres, its behaviour changes between postrges versions and there have been reports about it misbehaving https://github.com/input-output-hk/cardano-db-sync/issues/974. Counting blocks of epoch seems more clear...

I've implemented this [here](https://github.com/input-output-hk/cardano-db-sync/pull/1086/files#diff-b5afcb79b851e1393424098f9ea53a878dd64d5215e6d8b29539e1d5db8af015R68), any review would be welcome. I extract a slice from the `_delegations` of the snapshot and query the `_stake` for each stake credentials. I'm not sure...

I'll take a look at these next days.

> What do you mean by "return a passing Result"? The property doesn't fail

Yes, this is what I meant. I personally agree a bit more with the second option: make `runParallelCommands` fail on exceptions, since it doesn't complete histories.

> Another way to think of it is that `runParallelCommands` should be used when there's no fault injection (exceptions), while `runParallelCommands'` should be used when there's fault injection. Yes exactly.