Kevin Newton

Results 103 comments of Kevin Newton

> @kddnewton We can actually mark the nodes which doesn't have any fields as done right? Yes you're right, I just marked them all as completed.

@MatheusRich > @kddnewton calling dibs on ArrayNode That one already has an open PR. But the others should be good!

To answer your question — there is not currently a way. I think that discussion is still taking place here: https://bugs.ruby-lang.org/issues/20024.

Interesting. Can we detect if it's gcc and use it conditionally?

Sorry I'm not entirely clear. Is it safe to replace `c99` with `gnu99`? I'm happy to do that, I just don't want to break anything... It appears from some cursory...

Going to close this for now until we have more information

Yeah I'm tempted to not add any additional flags as it's already pretty confusing. But I'm working through the CRuby failures right now, trying to get to the actual problems....

Thanks @egiurleo! I ended up going a slightly different way because after living with `operator_` being different in Ruby vs C it was weirding me out. So I renamed those...

Something very odd is happening with `Parser::Source::Buffer`. We're passing in a big5-encoded string, and it looks like it's transcoding it to utf-8. So then when it hits the multi-byte characters...

Thanks @CKolkey I've opened https://github.com/ruby/prism/pull/2563 to fix this. If you find more, feel free to open new tickets.