Kayla Atropos
Kayla Atropos
I'm mostly found that shoving data into "global variables effectively" to be a reasonable way to pass data between modules, especially if you define the spec of the module's data...
While this work is absolutely stunning, I am going to ask if there is is a chance that some of these features, like the battery monitor, or library, may make...
We should consider adding a make arg for this as well, and possibly (in a different PR) make a make command that should be run before committing to ensure that...
I like these changes. I started BLE splits similarly, but merged them for stupid reasons, and regretted it. Glad to see them split back out. As for integrating other modules/extensions...
A few things that some don't realize about splits. - Modules don't always have to match - Even the firmware doesn't have to match. KMK isn't required on the secondary...
"As for this PR: sure, I'm all for it if it works. Enums vs classes... I'd prefer classes, looks more pythonic to me, easier to extend -- but it's a...
Any other changes that you want to make, or should I prep for final review/merge?
> I would like to add the I2C protocol and it looks like I better wait for this before. But this PR seems dead... What is the status of this...
Well, I was just about to bring up words that don't exist, but you clearly know the tool. I like this.
Looks good to me. I made a comment about a make arg, and that would apply to any tool like these.