Kamil Braun

> We might move size to the start. Unfortunately the size types might be different; `basic_sstring` is templated by the size type used for non-ssod strings. If the size types...

Do we actually save anything by using `int8_t` for the size type for the SSO case? Maybe we could just fix the size type to be `size_t` and use it...

Yeah, assuming we don't adjust `max_size`. Right now the default `max_size` (in definition of `sstring`) is `15`. How harmful would increasing that (to e.g. `22`) be?

@avikivity > "preserve the value category" means future::then should behave differently depending on the value category of its parameter (i.e. also remember if it was passed an ordinary reference). I...

Should we start preserving the value category during the deprecation period? Or should we instantly switch to using `std::move` everywhere - and always call the rvalue-reference version of `operator()` if...

Example usage: https://github.com/scylladb/scylla/pull/10353

@gusev-p can you explain the last force push?

@gleb-cloudius @gusev-p is this PR ready?

Yes the test is disabled in `master`, rebase

Qd