Kirk Bonney

[FEATURE] SSL certificate verification failure

1

**Describe the bug** When I attempt to run grayskull on one of my public repositories I receive an SSL_CERTIFICATE_VERIFY_FAILED error. Steps to reproduce the behavior: 1. Install grayskull in a...

## Summary Related: #409 When the `units` keyword argument is set to "SI" in `write_inp`, WNTR will generate an INP file with values in SI units and the UNITS option...

**Summary** Implement the ability to parse PBV from INP files **Additional context** This is currently captured in the limitations section of the documenation. #354

Results and Control updates for testing and stepwise.

2

## Summary - Extended functionality of the results object by adding the ability to perform operations such as addition between two results objects. - Added `_shift` method to Control base...

## Summary Below produces a minimal working example of the bug: from os.path import join import wntr ``` wn_path = "io.inp" wn = wntr.network.WaterNetworkModel(wn_path) wn_gis = wn.to_gis() wn_gis.junctions.index.name = "my_index"...

Adding vertex plotting option to plot_network

1

Provide a summary of the proposed changes, describe tests and documentation, and review the acknowledgement below. ## Summary This PR adds the ability to plot vertices to the `plot_network` function....

## Summary This PR contains the current work done towards stepwise simulation. I will populate the summary with more details as the PR gets refined ## Tests and documentation Some...

## Summary This PR contains the current work done towards real-time simulation. I will populate the summary with more details as the PR gets refined ## Tests and documentation Some...

JOSS Review

11

Hi @andreArtelt, nice work on the package and paper. Below are some comments for improving both. The only points that I need resolved to complete my review are marked by...

Addition of raster functionality

7

## Summary This PR adds the function `sample_raster` to the `wntr.gis` module. The function samples a raster file at the coordinate points of the provided geodataframe (e.g., junctions from WaterNetworkGIS)....